Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Announce to one tracker at a time #18

Closed
gabrieldemian opened this issue Aug 28, 2023 · 2 comments
Closed

Announce to one tracker at a time #18

gabrieldemian opened this issue Aug 28, 2023 · 2 comments
Labels
good first issue Good for newcomers

Comments

@gabrieldemian
Copy link
Owner

Before we download a torrent, we must send an announce to the tracker, and right now I'm sending announces to all trackers to see which one answers first. Should be as simple as to just remove the iteration.

Feedback from dgroshev on reddit:

"connecting to all trackers like this is a violation of BEP12. Yes it's a pretty common violation, but a violation nonetheless"
@gabrieldemian gabrieldemian added the good first issue Good for newcomers label Aug 28, 2023
@gabrieldemian gabrieldemian changed the title Connect to one tracker at a time Announce to one tracker at a time Aug 28, 2023
@gabrieldemian
Copy link
Owner Author

http://www.bittorrent.org/beps/bep_0012.html

@gabrieldemian gabrieldemian mentioned this issue Sep 23, 2023
Merged
@gabrieldemian
Copy link
Owner Author

fixed by PR #25

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gabrieldemian