Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Better logs #21

Closed
gabrieldemian opened this issue Aug 31, 2023 · 0 comments · Fixed by #25
Closed

Better logs #21

gabrieldemian opened this issue Aug 31, 2023 · 0 comments · Fixed by #25
Labels
good first issue Good for newcomers

Comments

@gabrieldemian
Copy link
Owner

To have a good daemon, good log is essential.
Our logs could be much better, most the logs are on the info level when they could be separated into debug and trace.
Also, the logs of the peer protocol could have only 1 line instead of 3, for example, a handshake log has 3 lines:

info!("---------");
info!("{peer_addr} Handshake ");
info!("---------");

could be simplified to only 1 log

info!("{peer_addr} Handshake ......");
@gabrieldemian gabrieldemian added the good first issue Good for newcomers label Aug 31, 2023
@gabrieldemian gabrieldemian mentioned this issue Sep 23, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant