✨ : github module import #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juwit
force-pushed
the
github_module_import
branch
from
35030fc to
09b2c49
Compare
juwit
added
✨ feature:modules
juwit
force-pushed
the
github_module_import
branch
6 times, most recently
from
6f0fff7 to
61591fe
Compare
When passing parameters to the RestTemplate exchange method, spring url-encodes the parameter. This behaviour is not desirable for GithubRawContent, as the project ID contains a '/'
Github serves raw content in base 64 with line feeds for large files. We have to remove them before decoding the content.
`Mockito.verifyZeroInteractions` is deprecated since 3.x.x. Using `verifyNoInteraction` instead
to remote the need of mockito inline
juwit
force-pushed
the
github_module_import
branch
from
61591fe to
86eecd3
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
cdubuisson
approved these changes
Jan 15, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.