Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add new option "Timeout" for pipeline jobs #111

Open
michelvocks opened this issue Sep 24, 2018 · 3 comments
Open

Add new option "Timeout" for pipeline jobs #111

michelvocks opened this issue Sep 24, 2018 · 3 comments
Assignees

Comments

@michelvocks
Copy link
Member

By default, a job from a pipeline run is running for ever and this is the expected behavior. We don't know how long a job should run and therefore we don't set a global timeout for pipeline jobs.

Therefore, we should provide the user the possibility to manually set a job timeout via job declaration: https://github.com/gaia-pipeline/protobuf/blob/master/plugin.proto#L15

This also includes updates for all SDKs. For example: https://github.com/gaia-pipeline/gosdk/blob/master/job.go#L29

@Skarlso
Copy link
Member

Skarlso commented Sep 25, 2018

I wonder. The plugins have health checks. We could intentionally ping a plugin if it's still healthy and just working on something for a long time. If a healthcheck fails after X times of trying, I think it should be safe to kill the job off. If the health check fails that generally would mean that the plugin/job is dead. Not?

EDIT: Never mind. A job could still be frozen while the plugin itself responds as healthy.

@michelvocks
Copy link
Member Author

That's already implemented by the go-plugin. If the health check does not respond, go-plugin will terminate the process. At least that is what I can read from the code 😄

@Skarlso Skarlso self-assigned this Apr 27, 2020
@Skarlso
Copy link
Member

Skarlso commented Apr 27, 2020

I'll add this. Plus the UI for it.

@Skarlso Skarlso pinned this issue Apr 27, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants