Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Opt glTF texture parse comments #2569

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

GuoLei1990
Copy link
Member

@GuoLei1990 GuoLei1990 commented Feb 26, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

Summary by CodeRabbit

  • Bug Fixes
    • Clarified a warning message regarding the use of a texture transformation extension to correctly indicate that the extension is not being applied.

Copy link

coderabbitai bot commented Feb 26, 2025

Walkthrough

The pull request updates a warning message in the GLTF material parser. Previously, the message suggested that base textures must always use the KHR_texture_transform extension. With the new change, the warning now states that the extension will be ignored. No modifications were made to the public or exported interfaces.

Changes

File Change Summary
packages/.../GLTFMaterialParser.ts Updated warning message: now indicates that the KHR_texture_transform extension is ignored rather than applied.

Suggested reviewers

  • zhuxudong

Poem

I'm a little rabbit, hopping with delight,
Coding under moonbeams in the soft twilight.
The warning now whispers, "Ignore the transform,"
Adding clarity to textures in a calm reform.
With joyful hops and ASCII beats so bright,
I celebrate the change with burrowed insight!

Tip

CodeRabbit's docstrings feature is now available as part of our Pro Plan! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9a28f37 and b2e1153.

📒 Files selected for processing (1)
  • packages/loader/src/gltf/parser/GLTFMaterialParser.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: e2e (22.x)
  • GitHub Check: codecov
🔇 Additional comments (1)
packages/loader/src/gltf/parser/GLTFMaterialParser.ts (1)

31-31: Clear warning message improvement.

The warning message has been updated to clearly indicate that the KHR_texture_transform extension will be ignored for the specified texture types, rather than the previous message which may have created confusion about its usage. This change improves clarity for developers working with GLTF materials that contain this extension.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.94%. Comparing base (9a28f37) to head (b2e1153).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...kages/loader/src/gltf/parser/GLTFMaterialParser.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2569   +/-   ##
=======================================
  Coverage   68.93%   68.94%           
=======================================
  Files         961      961           
  Lines      100271   100271           
  Branches     8655     8655           
=======================================
+ Hits        69121    69131   +10     
+ Misses      30890    30880   -10     
  Partials      260      260           
Flag Coverage Δ
unittests 68.94% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuoLei1990 GuoLei1990 requested a review from zhuxudong February 26, 2025 09:03
@GuoLei1990 GuoLei1990 changed the title refactor: opt comments Opt glTF texture parse comments Feb 26, 2025
@GuoLei1990 GuoLei1990 merged commit d245d90 into galacean:main Feb 26, 2025
8 of 9 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

修改 KHR_texture_transform 解析逻辑,仅解析并存储 baseColorTexture 的 transform
2 participants