Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix issue with ParentArticle images resolver #1693

Open
NickSto opened this issue Oct 25, 2022 · 0 comments
Open

Fix issue with ParentArticle images resolver #1693

NickSto opened this issue Oct 25, 2022 · 0 comments
Labels

Comments

@NickSto
Copy link
Member

NickSto commented Oct 25, 2022

#1692 changes every dynamic page to query for ParentArticles instead of Articles except /careers/. That page breaks when you convert the query to allParentArticle because of an issue with the images metadata field. This issue only comes up here because it's the only dynamic page to make use of the images field.

I think this is a sign that there's an issue with how the images resolver (resolveImages()) interacts with the copied data. We're properly adding resolveImages() to ParentArticle; it's not like we're copying the function or anything, so it's not that.

@NickSto NickSto added the bug label Oct 25, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant