Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

patch krakentools beta_diversity.xml #6553

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

mthang
Copy link
Contributor

@mthang mthang commented Nov 12, 2024

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

The header section of the krakentools beta_diversity.xml output file embedded the galaxy directory and It affects the file parsing in the downstream. Therefore, I made the simple patch by updating this wrapper. My colleague in Australia is submitting a workflow containing this tool to the workflowhub soon. I just patched the wrapper by adding the element_identifier to each input file.

Here's the screenshot of the beta_diversity output
Screenshot 2024-10-02 at 1 53 19 PM

Many thanks,

Copy link
Contributor

@bernt-matthias bernt-matthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a bump of the version.

Wondering:

  • should the output be tabular
  • so we want to have more output assertions?

@mthang
Copy link
Contributor Author

mthang commented Nov 13, 2024

I believe you refer to the wrapper version not the tool version. I will bump the beta_diversity wrapper version up.

Re:

  • should the output be tabular
    The output format is defined as txt in the wrapper not tabular
  • so we want to have more output assertions?
    any suggestion? can you clarify what other outputs should be included in the test unit.

@bernt-matthias
Copy link
Contributor

I believe you refer to the wrapper version not the tool version.

Yes.

The output format is defined as txt in the wrapper not tabular

The question is if this is correct :) The output looks pretty tabular to me :)

so we want to have more output assertions?

We could have an assertion that a line having the new identifiers in the output is included.

@mthang
Copy link
Contributor Author

mthang commented Nov 15, 2024

I bumped the galaxy from galaxy1 to galaxy2 and added the assertion to the test unit.

Re:
The question is if this is correct :) The output looks pretty tabular to me :)

It looked like a tabular to me in the beginning as well. Then, I looked closely and realised it's not tabular. They are just the header lines. see the attached.

beta_diversity

Thanks

@bernt-matthias
Copy link
Contributor

Its tab separated so it's tabular :) (# commend lines should be ignored).

I removed one extra requirement and included it directly in bioconda bioconda/bioconda-recipes#52125 as it should be. Saves us one container / environment (at least in new installations).

@mthang
Copy link
Contributor Author

mthang commented Nov 18, 2024

@bernt-matthias do you want me to replace "txt" with "tabular" in beta_diversity.xml wrapper? I can do that as well.

@bernt-matthias
Copy link
Contributor

Already did so in ad1217d :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants