-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
patch krakentools beta_diversity.xml #6553
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a bump of the version.
Wondering:
- should the output be tabular
- so we want to have more output assertions?
I believe you refer to the wrapper version not the tool version. I will bump the beta_diversity wrapper version up. Re:
|
Yes.
The question is if this is correct :) The output looks pretty tabular to me :)
We could have an assertion that a line having the new identifiers in the output is included. |
I bumped the galaxy from galaxy1 to galaxy2 and added the assertion to the test unit. Re: It looked like a tabular to me in the beginning as well. Then, I looked closely and realised it's not tabular. They are just the header lines. see the attached. Thanks |
Its tab separated so it's tabular :) (# commend lines should be ignored). I removed one extra requirement and included it directly in bioconda bioconda/bioconda-recipes#52125 as it should be. Saves us one container / environment (at least in new installations). |
@bernt-matthias do you want me to replace "txt" with "tabular" in beta_diversity.xml wrapper? I can do that as well. |
Already did so in ad1217d :) |
FOR CONTRIBUTOR:
The header section of the krakentools beta_diversity.xml output file embedded the galaxy directory and It affects the file parsing in the downstream. Therefore, I made the simple patch by updating this wrapper. My colleague in Australia is submitting a workflow containing this tool to the workflowhub soon. I just patched the wrapper by adding the element_identifier to each input file.
Here's the screenshot of the beta_diversity output
Many thanks,