Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Groot update DM path #6563

Merged
merged 5 commits into from
Nov 18, 2024
Merged

Conversation

hugolefeuvre
Copy link
Contributor

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)
    DM path was not the same in command wrapper and json file

@bernt-matthias
Copy link
Contributor

What's wrong with the old path?

@hugolefeuvre
Copy link
Contributor Author

What's wrong with the old path?

In the command part of the DM xml, data are downloaded into a repository called arg-annot.90 (in the case of arg-annot database), but in the json, at the end the path was in a repository called groot_database/data/arg-annot.90-1.1.2-13112024.
I'm not sure if the error stems from that, but it's the only difference with the tests I run in the tools section. The tool was integrated into Galaxy because the tests passed but once on the platform I encounter an error, you can find them here : https://usegalaxy.fr/u/hugo-lefeuvre/h/test-groot

@@ -1,2 +1,3 @@
arg-annot.90-16102024 arg-annot (90 percent identity) /tmp/tmpjmmj2x3o/galaxy-dev/tool-data/groot_database/data/arg-annot.90-16102024 1.1.2
arg-annot.90-1.1.2-16102024 arg-annot (90 percent identity) /tmp/tmpqdkgcsoq/galaxy-dev/tool-data/groot_database/data/arg-annot.90-1.1.2-16102024 1.1.2
arg-annot.90-1.1.2-15112024 arg-annot (90 percent identity) /tmp/tmpnlgwr_46/galaxy-dev/tool-data/arg-annot.90 1.1.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From your failing job it seems that the tool using the data tries to access tool-data/groot_database/data/arg-annot.90-1.1.2-13112024 which is not what the new version creates.

I definitely miss the groot_database/ part of the tool.

Copy link
Contributor

@bernt-matthias bernt-matthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likely the problem is that the data manager tool needs to place the files in a directory $out_file.extra_file_path instead of the job working directories.

I made the same error in a few data managers. See the fix here Helmholtz-UFZ/galaxy-tools#71

Copy link
Contributor

@bernt-matthias bernt-matthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess in the config file you need to replace

- "path": "/$database.$identity",
+ "path": "$database.$identity",

@hugolefeuvre
Copy link
Contributor Author

Likely the problem is that the data manager tool needs to place the files in a directory $out_file.extra_file_path instead of the job working directories.

I made the same error in a few data managers. See the fix here Helmholtz-UFZ/galaxy-tools#71

I made the change in the last commit, hope I've done it right

Copy link
Contributor

@bernt-matthias bernt-matthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Last thing to do is to increase VERSION_SUFFIX

Copy link
Contributor

@bernt-matthias bernt-matthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. Must have overlooked this :)

@bernt-matthias bernt-matthias merged commit 15ce75a into galaxyproject:main Nov 18, 2024
12 checks passed
@hugolefeuvre
Copy link
Contributor Author

Sorry. Must have overlooked this :)

No problem, thanks for the review !

@hugolefeuvre hugolefeuvre deleted the groot_update branch November 18, 2024 15:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants