-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Groot update DM path #6563
Groot update DM path #6563
Conversation
What's wrong with the old path? |
In the command part of the DM xml, data are downloaded into a repository called arg-annot.90 (in the case of arg-annot database), but in the json, at the end the path was in a repository called |
@@ -1,2 +1,3 @@ | |||
arg-annot.90-16102024 arg-annot (90 percent identity) /tmp/tmpjmmj2x3o/galaxy-dev/tool-data/groot_database/data/arg-annot.90-16102024 1.1.2 | |||
arg-annot.90-1.1.2-16102024 arg-annot (90 percent identity) /tmp/tmpqdkgcsoq/galaxy-dev/tool-data/groot_database/data/arg-annot.90-1.1.2-16102024 1.1.2 | |||
arg-annot.90-1.1.2-15112024 arg-annot (90 percent identity) /tmp/tmpnlgwr_46/galaxy-dev/tool-data/arg-annot.90 1.1.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From your failing job it seems that the tool using the data tries to access tool-data/groot_database/data/arg-annot.90-1.1.2-13112024
which is not what the new version creates.
I definitely miss the groot_database/
part of the tool.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likely the problem is that the data manager tool needs to place the files in a directory $out_file.extra_file_path
instead of the job working directories.
I made the same error in a few data managers. See the fix here Helmholtz-UFZ/galaxy-tools#71
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess in the config file you need to replace
- "path": "/$database.$identity",
+ "path": "$database.$identity",
I made the change in the last commit, hope I've done it right |
data_managers/data_manager_groot_database_downloader/data_manager_conf.xml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Last thing to do is to increase VERSION_SUFFIX
...ta_manager_groot_database_downloader/data_manager/data_manager_groot_database_downloader.xml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry. Must have overlooked this :)
No problem, thanks for the review ! |
FOR CONTRIBUTOR:
DM path was not the same in command wrapper and json file