Cast more functions from double to int

[gaocegege]

• Anything named "mode":
  • blendMode()
  • colorMode()
  • ellipseMode()
  • imageMode()
  • rectMode()
  • shapeMode()
  • textureMode()
  • textMode()
• Other configuration-setting functions:
  • pixelDensity()
  • strokeCap()
  • strokeJoin()
  • textureWrap()

[jeremydouglass]

If I recall right, originally you were putting casts from double to int in BuiltinApplet for anything that would set a global configuration variable. However, rather than adding more (from this list), all the casting was removed.

https://github.com/gaocegege/Processing.R/commits/master/src/rprocessing/applet/BuiltinApplet.java

Now the issue is closed. Can you remind me why the casting was removed, and how this was resolved?

[gaocegege]

I am not sure if I understand you. The mode functions such as blendMode accept int parameter but actually, it only accepts the constants defined in PConstants, so there is no need to cast those functions.

[jeremydouglass]

I mean, this issue was created when BuiltinApplet.java had things like this:

https://github.com/gaocegege/Processing.R/blob/97dd10c5020b10f8eb1caec58b08dc0636c165c5/src/rprocessing/applet/BuiltinApplet.java#L61-L63

and later on cast warnings were added:

https://github.com/gaocegege/Processing.R/blob/c3b98be2657921b7b4efb274c74b6a91443df74d/src/rprocessing/applet/BuiltinApplet.java#L73-L76

...so is this issue resolved because that whole approach was dropped in favor of using PConstants as arguments? I believe that everything in the list takes a PConstant except pixelDensity().

[gaocegege]

Yeah the colorMode could be removed. Only pixelDensity should be casted manually.