Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feat/add keyword focused #121

Merged
merged 7 commits into from
Jun 15, 2017
Merged

Feat/add keyword focused #121

merged 7 commits into from
Jun 15, 2017

Conversation

hawkingrei
Copy link
Contributor

@hawkingrei hawkingrei commented Jun 15, 2017

I add a keyword focused.you can test by the following R code.

settings <- function() {
    size(500, 500)
}

draw <- function() {
   stdout$print(focused)
   stdout$print("\n")
}

@@ -324,6 +324,26 @@ private boolean isMixMode() {
}

/**
*
Copy link
Member

@gaocegege gaocegege Jun 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

Could you put these two functions in BuiltinApplet? I think the built-in function wrapper should be there

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  👊

Copy link
Contributor Author

@hawkingrei hawkingrei Jun 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaocegege It is hard to move these two functions into BuiltinApplet.Because those functions need to Renjin engine putting the keyword into R environment when the focused event happen.but Renjin engine initializes in the RLangPApplet.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it.

@gaocegege
Copy link
Member

LGTM

@gaocegege gaocegege merged commit 05b3816 into processing-r:master Jun 15, 2017
@jeremydouglass
Copy link
Member

@hawkingrei -- thank you for contributing!

@gaocegege -- should we add an R version of the standard reference example -- https://processing.org/reference/focused.html ?

(BTW, shouldn't you be working on linuxcon right now??)

@gaocegege
Copy link
Member

gaocegege commented Jun 15, 2017

Yeah, I will add it after linuxcon. It is 23:00 in Shanghai, so it is break time 😄

And @hawkingrei is the first contributor except you and me, I want to be enthusiastic 😺

@gaocegege gaocegege mentioned this pull request Jun 16, 2017
2 tasks
@gaocegege gaocegege modified the milestone: Evaluation 1 Jun 22, 2017
@jeremydouglass
Copy link
Member

I think the focused reference sketch was never added.

@gaocegege
Copy link
Member

I have opened a new issue: #160

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants