-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Feat/add keyword focused #121
Feat/add keyword focused #121
Conversation
@@ -324,6 +324,26 @@ private boolean isMixMode() { | |||
} | |||
|
|||
/** | |||
* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
Could you put these two functions in BuiltinApplet? I think the built-in function wrapper should be there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gaocegege It is hard to move these two functions into BuiltinApplet
.Because those functions need to Renjin engine putting the keyword into R environment when the focused event happen.but Renjin engine initializes in the RLangPApplet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it.
LGTM |
@hawkingrei -- thank you for contributing! @gaocegege -- should we add an R version of the standard reference example -- https://processing.org/reference/focused.html ? (BTW, shouldn't you be working on linuxcon right now??) |
Yeah, I will add it after linuxcon. It is 23:00 in Shanghai, so it is break time 😄 And @hawkingrei is the first contributor except you and me, I want to be enthusiastic 😺 |
I think the focused reference sketch was never added. |
I have opened a new issue: #160 |
I add a keyword
focused
.you can test by the following R code.