feat: add mouseX and mouseY #122

hawkingrei · 2017-06-15T17:11:11Z

😈 I add new keywords mouseX and mouseY. You can test by the following R code

draw <- function() {
    background(as.integer(204))
    line(mouseX, mouseY, 80, mouseY);
}

gaocegege · 2017-06-16T00:18:33Z

Hi, there is one conflicting file, please resolve it 😄

gaocegege · 2017-06-16T00:22:26Z

src/rprocessing/RLangPApplet.java

    this.renjinEngine.put("width", width);
    this.renjinEngine.put("height", height);
    this.renjinEngine.put("displayWidth", displayWidth);
    this.renjinEngine.put("displayHeight", displayHeight);
-    // this.renjinEngine.put("focused", focused);


I think the conflict is caused by this statement

Yes, I enabled that line in 912d23b -- before, processing$focused worked, but focused did not. Now focused works. We should be able to merge the new mouseX / mouseY code and leave that line enabled -- unless I'm misunderstanding something.

@jeremydouglass I think you are right 😄

And LGTM

gaocegege · 2017-06-16T04:29:49Z

LGTM

gaocegege reviewed Jun 16, 2017

View reviewed changes

feat: add mouseX and mouseY

d95c03c

gaocegege merged commit 786ef8f into processing-r:master Jun 16, 2017

gaocegege modified the milestone: Evaluation 1 Jun 22, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add mouseX and mouseY #122

feat: add mouseX and mouseY #122

hawkingrei commented Jun 15, 2017 •

edited

Loading

gaocegege commented Jun 16, 2017

gaocegege Jun 16, 2017

jeremydouglass Jun 16, 2017 •

edited

Loading

hawkingrei Jun 16, 2017 •

edited

Loading

gaocegege Jun 16, 2017

gaocegege commented Jun 16, 2017

feat: add mouseX and mouseY #122

feat: add mouseX and mouseY #122

Conversation

hawkingrei commented Jun 15, 2017 • edited Loading

gaocegege commented Jun 16, 2017

gaocegege Jun 16, 2017

Choose a reason for hiding this comment

jeremydouglass Jun 16, 2017 • edited Loading

Choose a reason for hiding this comment

hawkingrei Jun 16, 2017 • edited Loading

Choose a reason for hiding this comment

gaocegege Jun 16, 2017

Choose a reason for hiding this comment

gaocegege commented Jun 16, 2017

hawkingrei commented Jun 15, 2017 •

edited

Loading

jeremydouglass Jun 16, 2017 •

edited

Loading

hawkingrei Jun 16, 2017 •

edited

Loading