Skip to content

Commit 3d2db95

Browse files
committed
Remove CStereoscopicsManager instance
The first step in killing globals is to identify if the service is instantiated as a global or singleton. In this case, the service is a singleton. Remove this instance. Singletons usually have private constructors. Make all constructors public.
1 parent 5141e05 commit 3d2db95

File tree

2 files changed

+0
-11
lines changed

2 files changed

+0
-11
lines changed

xbmc/guilib/StereoscopicsManager.cpp

-6
Original file line numberDiff line numberDiff line change
@@ -106,12 +106,6 @@ CStereoscopicsManager::CStereoscopicsManager(void)
106106

107107
CStereoscopicsManager::~CStereoscopicsManager(void) = default;
108108

109-
CStereoscopicsManager& CStereoscopicsManager::GetInstance()
110-
{
111-
static CStereoscopicsManager sStereoscopicsManager;
112-
return sStereoscopicsManager;
113-
}
114-
115109
void CStereoscopicsManager::Initialize(void)
116110
{
117111
// turn off stereo mode on XBMC startup

xbmc/guilib/StereoscopicsManager.h

-5
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,6 @@ class CStereoscopicsManager : public ISettingCallback,
4848
CStereoscopicsManager(void);
4949
~CStereoscopicsManager(void) override;
5050

51-
/*!
52-
* @return static instance of CStereoscopicsManager
53-
*/
54-
static CStereoscopicsManager& GetInstance();
55-
5651
void Initialize(void);
5752
RENDER_STEREO_MODE GetStereoMode(void);
5853
void SetStereoModeByUser(const RENDER_STEREO_MODE &mode);

0 commit comments

Comments
 (0)