Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

☂️ Track MCM IT related issues #787

Open
1 of 6 tasks
rishabh-11 opened this issue Feb 22, 2023 · 1 comment
Open
1 of 6 tasks

☂️ Track MCM IT related issues #787

rishabh-11 opened this issue Feb 22, 2023 · 1 comment
Labels
area/testing Testing related kind/bug Bug kind/epic Large multi-story topic lifecycle/stale Nobody worked on this for 6 months (will further age) needs/planning Needs (more) planning with other MCM maintainers priority/2 Priority (lower number equals higher priority)

Comments

@rishabh-11
Copy link
Contributor

rishabh-11 commented Feb 22, 2023

How to categorize this issue?

/area testing
/kind epic
/priority 2

What happened:

  • Enhance pipeline setup for IT to adapt to gardener environment changes #853
  • Update MCM and MC versions to latest for local deployment #675
  • Cleanup after IT is not working properly #789
  • Other improvements
    • Debugging IT is tough right now, the tests should specify which machine objects they created
    • Check the status of machine also once node object is confirmed, because it can happen node obj is there, but machine is still Pending but tests are still passing.
    • Only run the vendored version of MCM during IT in pipeline
  • Enhance IT with tests for the following logics
    - Bootstrap token creation and deletion should be checked
    - Unhealthy machine is being marked Unknown should be checked
    - Draining mechanism should be checked
    - Meltdown mechanism should be checked
    - Safety controllers should be checked
  • Validate MCM with IT
    • Currently MCM doesn't have any integration tests. Also we don't gaurantee in pipeline tests that it would not have any runtime errors.
      • Possible soln: A small kind cluster with machine crds installed , then we could start MCM for that and confirm Processing machineDeployment … log is coming.
@rishabh-11 rishabh-11 added the kind/bug Bug label Feb 22, 2023
@gardener-robot gardener-robot added area/testing Testing related priority/2 Priority (lower number equals higher priority) labels Feb 22, 2023
@himanshu-kun
Copy link
Contributor

Post Grooming Discussion

  • We see that we just wait for deletionTimestamp to be put on the machine resource(waiting for delete event), and don't wait for resource to be actually deleted from etcd
  • Restarting MC doesn't work for cleanup

@himanshu-kun himanshu-kun changed the title Machine Resources not cleaned up when MC process fails in IT ☂️ Track MCM IT related issues Feb 23, 2023
@himanshu-kun himanshu-kun added kind/epic Large multi-story topic needs/planning Needs (more) planning with other MCM maintainers and removed kind/bug Bug labels Feb 23, 2023
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Aug 6, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
area/testing Testing related kind/bug Bug kind/epic Large multi-story topic lifecycle/stale Nobody worked on this for 6 months (will further age) needs/planning Needs (more) planning with other MCM maintainers priority/2 Priority (lower number equals higher priority)
Projects
None yet
Development

No branches or pull requests

3 participants