Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Shell completion script for the builder #56

Open
fwilhe opened this issue Jan 24, 2024 · 4 comments
Open

Shell completion script for the builder #56

fwilhe opened this issue Jan 24, 2024 · 4 comments
Assignees
Labels
kind/enhancement Enhancement, improvement, extension

Comments

@fwilhe
Copy link
Member

fwilhe commented Jan 24, 2024

What would you like to be added:

It would be great if the builder had completion, reading out the actual available features in the current image being built.

For example in GL it should be like

./build k[tab][tab]
kvm

cf:
https://iridakos.com/programming/2018/03/01/bash-programmable-completion-tutorial

Why is this needed:

Developer experience would be better, both for seasoned contributors and for newcomers.

@Akendo
Copy link
Contributor

Akendo commented May 21, 2024

Thanks for pointing me towards here. In general, I do not use shell. Instead, I would use complgen. I might take a look at this week.

@Akendo Akendo changed the title Bash completion script for the builder Shell completion script for the builder May 21, 2024
@Akendo Akendo self-assigned this May 21, 2024
@Akendo
Copy link
Contributor

Akendo commented May 28, 2024

I've taken some time to understand a bit more how we're building our product and derived some more ideas to build up the completion. This works for fish more well now:

Image

@Akendo
Copy link
Contributor

Akendo commented May 29, 2024

I'm currently unable to perform proper subword matches after defined the platform. I've created an issue with the project , but I might do something wrong here. If this is not going to get address until EOW, we might close this down and move on to more important tasks.

@Akendo
Copy link
Contributor

Akendo commented May 29, 2024

The problem was resolved. Thanks to @nkraetzschmar for pointing to my error. We have now a working MVP for bash.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
kind/enhancement Enhancement, improvement, extension
Projects
None yet
Development

No branches or pull requests

2 participants