Skip to content

Commit 215d663

Browse files
joerundegarg-amit
authored andcommitted
[Bugfix] Fix 3.12 builds on main (vllm-project#8510)
Signed-off-by: Joe Runde <Joseph.Runde@ibm.com> Signed-off-by: Amit Garg <mitgarg17495@gmail.com>
1 parent 0a02857 commit 215d663

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

Dockerfile

-4
Original file line numberDiff line numberDiff line change
@@ -182,10 +182,6 @@ FROM vllm-base AS test
182182
ADD . /vllm-workspace/
183183

184184
# install development dependencies (for testing)
185-
# A newer setuptools is required for installing some test dependencies from source that do not publish python 3.12 wheels
186-
# This installation must complete before the test dependencies are collected and installed.
187-
RUN --mount=type=cache,target=/root/.cache/pip \
188-
python3 -m pip install "setuptools>=74.1.1"
189185
RUN --mount=type=cache,target=/root/.cache/pip \
190186
python3 -m pip install -r requirements-dev.txt
191187

requirements-common.txt

+1
Original file line numberDiff line numberDiff line change
@@ -29,4 +29,5 @@ importlib_metadata
2929
mistral_common >= 1.4.0
3030
pyyaml
3131
six>=1.16.0; python_version > '3.11' # transitive dependency of pandas that needs to be the latest version for python 3.12
32+
setuptools>=74.1.1; python_version > '3.11' # Setuptools is used by triton, we need to ensure a modern version is installed for 3.12+ so that it does not try to import distutils, which was removed in 3.12
3233
einops # Required for Qwen2-VL.

0 commit comments

Comments
 (0)