Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[1.0] Transliterate all GraphQL names to avoid invalid name errors #1111

Closed
KyleAMathews opened this issue Jun 6, 2017 · 4 comments
Closed
Labels
help wanted Issue with a clear description that the community can help with. stale? Issue that may be closed soon due to the original author not responding any more.

Comments

@KyleAMathews
Copy link
Contributor

GraphQL is unlikely to ever allow for names other than /(a-zA-Z0-9_)/ so we need to work within that.

This comment suggested using this package https://github.com/andyhu/transliteration

/cc @jquense

@KyleAMathews KyleAMathews mentioned this issue Jun 9, 2017
@jquense
Copy link
Contributor

jquense commented Jun 9, 2017

It seems reasonable to me, but i'm not really familar with whether that's a viable strategy here. My limited experience with transliteration tho would lead me to think it would cause confusion or ambiguity. Depending on the language there really isn't always "one way" to transliterate something so it may be unclear to a consumer what their fields were turned into. It doesn't help with the non semantic characters either unfortunately :/

@KyleAMathews
Copy link
Contributor Author

Ok let's leave this open for now until someone working in a non-english language has trouble and we can work out with them a good solution to this.

Yeah the tradeoff is a) transliterate and risk confusing people on why their field names changed or b) don't transliterate and force people to rename their fields causing potential confusion + possibly not being able to easily use Gatsby if it's not possible or easy to change/transform field names in their data pipeline.

@jbolda jbolda added GraphQL help wanted Issue with a clear description that the community can help with. labels Jun 28, 2017
@stale
Copy link

stale bot commented Dec 26, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Dec 26, 2017
@stale
Copy link

stale bot commented Jan 10, 2018

This issue has been automatically closed due to inactivity.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
help wanted Issue with a clear description that the community can help with. stale? Issue that may be closed soon due to the original author not responding any more.
Projects
None yet
Development

No branches or pull requests

3 participants