Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(gatsby-transformer-remark): Check key before trying to get cache #19288

Merged
merged 3 commits into from
Nov 13, 2019
Merged

fix(gatsby-transformer-remark): Check key before trying to get cache #19288

merged 3 commits into from
Nov 13, 2019

Conversation

mathieudutour
Copy link
Contributor

@mathieudutour mathieudutour commented Nov 5, 2019 •
edited
Loading

Description

  • make sure it's something we want to cache before trying to get the cache of the markdown node

Related Issues

Fixes #16703

@mathieudutour mathieudutour requested a review from a team as a code owner November 5, 2019 21:23
@muescha
Copy link
Contributor

muescha commented Nov 6, 2019

I read there is contentDigest missing. Is this missing contentDigest a bug?

@mathieudutour
Copy link
Contributor Author

It’s not really. The transformer passes the function to its plugins, which can call it to generate html. But when it’s called from plugins, it does not have the internal property.

@mathieudutour @sidharthachatterjee
remove unnecessary !!
73922cb 
Co-Authored-By: Sidhartha Chatterjee <me@sidharthachatterjee.com>
sidharthachatterjee
sidharthachatterjee approved these changes Nov 13, 2019
View reviewed changes
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@sidharthachatterjee sidharthachatterjee changed the title fix trying to get cache for md node fix(gatsby-transformer-remark): Check key before trying to get cache Nov 13, 2019
@sidharthachatterjee sidharthachatterjee merged commit 8b8293d into master Nov 13, 2019
@delete-merged-branch delete-merged-branch bot deleted the f/fix-getting-md-cache branch November 13, 2019 09:55
@cartant cartant mentioned this pull request Dec 8, 2019
Closed
@ornotandrew ornotandrew mentioned this pull request Apr 11, 2020
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sidharthachatterjee sidharthachatterjee sidharthachatterjee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gatsby-remark-images error if using markdownCaptions: true
3 participants
@mathieudutour @muescha @sidharthachatterjee