tests: Update pluginOptionsSchema tests #27904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
laurieontech
added
topic: plugins
|
Thanks for the PR! I certainly agree with the docs update, I'm less convinced that we need to look at both |
mxstbr
previously approved these changes
Nov 13, 2020
There was a problem hiding this comment.
This seems like a good idea to me, as it showcases the full API of testPluginOptionsSchema for people who are looking at our usage of it! Thank you @MichaelDeBoey!! 👍
MichaelDeBoey
force-pushed
the
update-plugin-validation-tests
branch
from
dde4eac
to
443f8e8
Compare
|
@laurieontech @mxstbr I think this one can be merged, no? 🤔 |
|
@MichaelDeBoey Max and Laurie no longer work at Gatsby, but I can look at this. The tests are failing now. Are you able to see why? |
MichaelDeBoey
force-pushed
the
update-plugin-validation-tests
branch
from
443f8e8
to
5fa2af1
Compare
MichaelDeBoey
force-pushed
the
update-plugin-validation-tests
branch
from
5fa2af1
to
57b2428
Compare
|
@ascorbic Tests should be fine now |
LekoArts
approved these changes
Nov 23, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring tests in line with the docs