Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

expand_gz_topic_names parameter does not work #529

Closed
elkuno213 opened this issue Apr 7, 2024 · 2 comments
Closed

expand_gz_topic_names parameter does not work #529

elkuno213 opened this issue Apr 7, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@elkuno213
Copy link

elkuno213 commented Apr 7, 2024

Environment

  • OS Version: Ubuntu 22.04
  • Source or binary build? binary build by apt, version iron

Description

  • Expected behavior: when expand_gz_topic_names is true, the namespace on Gazebo should be changed.
  • Actual behavior: the namespace does not change and this parameter cannot be found via ros2 param list.

Steps to reproduce

  1. Follow the Example 6.
  2. Run this command:
ros2 run ros_gz_bridge parameter_bridge chatter@std_msgs/msg/String@ignition.msgs.StringMsg \
  --ros-args -p expand_gz_topic_names:=true -r __ns:=/demo
  1. In other terminal, run this command:
ign topic --list 
# Output: /chatter

The topic is still /chatter, not /demo/chatter as expected.

  1. Run other command to check whether the parameter is existing:
ros2 param list | grep expand_gz_topic_names
# Output: nothing found
  1. This code snippet shows that expand_gz_topic_names only works when config_file is given.

Output

image
image

@elkuno213 elkuno213 added the bug Something isn't working label Apr 7, 2024
@azeey
Copy link
Contributor

azeey commented Apr 8, 2024

expand_gz_topic_names was added recently in #512 and ported to iron in #516. It has not been released yet (see https://github.com/gazebosim/ros_gz/blob/iron/ros_gz_bridge/CHANGELOG.rst). @ahcorde can you make a 0.254.1 release?

@azeey azeey moved this from Inbox to In progress in Core development Apr 8, 2024
@ahcorde
Copy link
Collaborator

ahcorde commented Apr 8, 2024

I made releases for Humble and Iron

@azeey azeey closed this as completed May 30, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Core development May 30, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants