-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Rules for Definition of Depth #4
Comments
Yes, sorry for the confusion. You are right. This is the disparity value however this might not have be the best definition of disparity. I will try to update the code with a better definition. In the meantime, you can get it in meters using:
|
I'm a little confused. And I have another question about your paper. |
The paper is correct however, when I released this code, I tried to clean up the code but the definition in the code doesn’t match the paper anymore. The above piece of code should work with the current version of the code. I will rectify it to be more consistent however I need to change both the code and the evaluation in the Carla dataset for that. (c_λ, c_φ) is the centre point of the camera in pixels which is likely to be (w/2,h/2). In our paper, the panorama was cropped vertically to ignore the sky and the roof of the sky however the crop wasn’t centered on the horizon. We took into account the crop in the parameter c_φ. This is not particularly important for depth estimation however it is required to transform the bounding boxes to the correct frame of reference for object detection. |
I wrote the following matlab code according to Eq.14,but i cant recover [x,y,z]. `
` |
I think that the problem is that the tan(b(1)) is the ratio x/z, not x itself. If you can assume z=1 which is the case when reprojecting rectilinear images it works but not when z can be negative. Here is the code that we used to reproject the centre of a bounding box:
where |
I still can't recover xyz according to your code,
but in your link:
So I wonder if it's only possible to use targets_z you gave.If so, how do i get the values of distance_pred_a and distance_pred_b? |
The code that you are refering to is related to the object detection network, not the depth estimation so it is not relevant. |
I can't recover xyz in many ways according to your paper. Can you give me a reference code for recovering xyz code in panoramic-depth-estimation please? Thank you
|
What problem do you get? I don’t have any reference code for what you are trying to do. We evaluated the depth map in image space and didn’t try to project it to a point cloud. |
I got the depth data from the. npy file, but I found that the nearer the point in the panoramic image, the greater the depth value. I want to know how you define the depth. thank you.
The text was updated successfully, but these errors were encountered: