Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

finish porting plugins to gdsfactory8 #437

Open
3 of 8 tasks
joamatab opened this issue Jul 10, 2024 · 6 comments
Open
3 of 8 tasks

finish porting plugins to gdsfactory8 #437

joamatab opened this issue Jul 10, 2024 · 6 comments
Labels
bug Something isn't working help wanted Extra attention is needed P1 High priority

Comments

@joamatab
Copy link
Contributor

joamatab commented Jul 10, 2024

Need to finish porting all plugins to gdsfactory8. It would be great if you could help with it.

@joamatab joamatab added the bug Something isn't working label Jul 10, 2024
@joamatab
Copy link
Contributor Author

@nikosavola could you help with elmer and palace?

@nikosavola
Copy link
Member

@nikosavola could you help with elmer and palace?

Sure, I haven't checked what fails yet.

@joamatab joamatab added help wanted Extra attention is needed P1 High priority labels Aug 5, 2024
@nikosavola
Copy link
Member

For capacitive simulations, this gmsh related function is not yet ported

def get_component_with_net_layers(
component,
layer_stack,
port_names: list[str],
delimiter: str = "#",
new_layers_init: tuple[int, int] = (10010, 0),
add_to_layerstack: bool = True,
) -> Component:
"""Returns a component where polygons touching a port are put on new logical layers.
Uses port's layer attribute to decide which polygons need to be renamed.
New layers are named "layername{delimiter}portname".
Args:
component: to process.
layer_stack: to process.
port_names: list of port_names to process into new layers.
delimiter: the new layer created is called "layername{delimiter}portname".
new_layers_init: initial layer number for the temporary new layers.
add_to_layerstack: True by default, but can be set to False to disable parsing of the layerstack.
"""
return NotImplementedError(
"Meshing component with net layers not implemented in gdsfactory8 yet."
)

@joamatab
Copy link
Contributor Author

joamatab commented Aug 8, 2024

@simbilod

@simbilod
Copy link
Collaborator

simbilod commented Aug 8, 2024

@simbilod

duplicate of #417

@simbilod
Copy link
Collaborator

For capacitive simulations, this gmsh related function is not yet ported

def get_component_with_net_layers(
component,
layer_stack,
port_names: list[str],
delimiter: str = "#",
new_layers_init: tuple[int, int] = (10010, 0),
add_to_layerstack: bool = True,
) -> Component:
"""Returns a component where polygons touching a port are put on new logical layers.
Uses port's layer attribute to decide which polygons need to be renamed.
New layers are named "layername{delimiter}portname".
Args:
component: to process.
layer_stack: to process.
port_names: list of port_names to process into new layers.
delimiter: the new layer created is called "layername{delimiter}portname".
new_layers_init: initial layer number for the temporary new layers.
add_to_layerstack: True by default, but can be set to False to disable parsing of the layerstack.
"""
return NotImplementedError(
"Meshing component with net layers not implemented in gdsfactory8 yet."
)

presumably fixed in #469

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working help wanted Extra attention is needed P1 High priority
Projects
None yet
Development

No branches or pull requests

3 participants