Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CREATE TABLE query does not return any success response #1186

Closed
1 of 2 tasks
gaurav274 opened this issue Sep 21, 2023 · 2 comments · Fixed by #1228
Closed
1 of 2 tasks

CREATE TABLE query does not return any success response #1186

gaurav274 opened this issue Sep 21, 2023 · 2 comments · Fixed by #1228
Labels
Help Wanted 🙏 Outside help would be appreciated, good for new contributors User Experience
Milestone

Comments

@gaurav274
Copy link
Member

Search before asking

  • I have searched the EvaDB issues and found no similar bug report.

Bug

 create_table_query = """
           CREATE TABLE IF NOT EXISTS HomeRentals (
               number_of_rooms INTEGER,
               number_of_bathrooms INTEGER,
               sqft INTEGER,
               location TEXT(128),
               days_on_market INTEGER,
               initial_price INTEGER,
               neighborhood TEXT(128),
               rental_price FLOAT(64,64)
           );"""

cur.query(create_table_query).df()

Empty DataFrame
Columns: []
Index: []

Environment

  • EvaDB - 0.3.6

Are you willing to submit a PR?

  • Yes I'd like to help by submitting a PR!
@gaurav274 gaurav274 added this to the v0.3.7 milestone Sep 21, 2023
@xzdandy xzdandy added the Help Wanted 🙏 Outside help would be appreciated, good for new contributors label Sep 22, 2023
@xzdandy
Copy link
Collaborator

xzdandy commented Sep 22, 2023

How does the following sound?
If created:

  • Table HomeRentals has been created.

If already exists

  • Table HomeRentals is already existed. Nothing added.

@uname-s
Copy link

uname-s commented Sep 23, 2023

I would rephrase:
Table HomeRentals is already existed. Nothing added.
as:
Table HomeRentals already exists.

The "Nothing added." part feels redundant but I can see the logic in being explicit that no action was taken.

@gaurav274 gaurav274 linked a pull request Sep 27, 2023 that will close this issue
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Help Wanted 🙏 Outside help would be appreciated, good for new contributors User Experience
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants