Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Notebook: Simulation of a 1D Magnetotelluric Problem #38

Open
lheagy opened this issue Mar 22, 2017 · 1 comment
Open

Notebook: Simulation of a 1D Magnetotelluric Problem #38

lheagy opened this issue Mar 22, 2017 · 1 comment
Assignees

Comments

@lheagy
Copy link
Member

lheagy commented Mar 22, 2017

Nice work @sgkang, I like the overall layout!

General comments

  • after the Purpose section, I would consider adding a Resources that includes a link to the SimPEG Mesh documentation and the MT section on EM geosci (and any other resources you think are particularly relevant). Phil's tutorials might be a good place to go as well (https://github.com/jokulhaup/directed_studies)
  • in terms of print statements, I think using format is better practice, eg.
print("Smallest cell size = {min_cs}".format(min_cs = 500*np.sqrt(100/fmax) / 4. ))

Specific comments

Physics

  • within the "Physics" section, the statement of the FDEM and TDEM equations is different, could we make them consistent?
    image

Discretization

  • In the Discretization section - we may want to provide a bit more detail in terms of showing the matrix structure of the discrete gradient (up to you on gauging the expected background of the audience).
  • In terms of the code, step 2 is very well commented, but step 1 would benefit from a few comments (eg. cs is cell size)
  • for step 2, there is a lot that happens in that cell. I have included a screen shot below where I would consider breaking up the pieces (and at each step outputting a plot or statement).
    • for the physical properties, having a plot will be helpful for when you suggest going back and changing the conductivity structure
    • when you create the differential operators, using an imshow plot to show the structure would be valuable
      image

What to Solve

  • to simplify things a bit in the construction of the A matrix, instead of creating tempUp, tempDown,
    image
    I would do it in one go and use spacing / indentation to have it look like the math
A = sp.vstack([
    sp.hstack([Grad, 1j*omega*Mmu]),
    sp.hstack([Msighat, Div])
])

Explore

  • for the plotting, I would suggest using different axes (eg plt.subplots(1,2)) for the apparent resistivity and phase (and include y-axis labels :) )
@lheagy
Copy link
Member Author

lheagy commented Mar 22, 2017

I am happy to help get this launched whenever you are happy with it (there is some cleanup in the doc-structure that needs to be done to get this moving!)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants