Skip to content

Support async ORM - sqlalchemy 2.0 #279

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
mavwolverine opened this issue Feb 10, 2024 · 2 comments · Fixed by #308
Closed

Support async ORM - sqlalchemy 2.0 #279

mavwolverine opened this issue Feb 10, 2024 · 2 comments · Fixed by #308
Assignees

Comments

@mavwolverine
Copy link
Contributor

No description provided.

@mavwolverine mavwolverine changed the title Support async ORM - sqlalchemy Support async ORM - sqlalchemy 2.0 Feb 10, 2024
@mavwolverine
Copy link
Contributor Author

mavwolverine commented Feb 16, 2024

@apotterri

Since sqlalchemy still supports events, I am guessing the current code should support sqlalchemy 2.0.

@petecheslock
Copy link
Contributor

Currently it looks like we are not capturing events with the 2.0 release due to a deprecated feature on sqlalchemy

_appmap/test/test_sqlalchemy.py::TestSQLAlchemy::test_sql_capture
  /Users/petecheslock/repos/appmap-python/_appmap/test/test_sqlalchemy.py:26: RemovedIn20Warning: Deprecated API features detected! These feature(s) are not compatible with SQLAlchemy 2.0. To prevent incompatible upgrades prior to updating applications, ensure requirements files are pinned to "sqlalchemy<2.0". Set environment variable SQLALCHEMY_WARN_20=1 to show all deprecation warnings.  Set environment variable SQLALCHEMY_SILENCE_UBER_WARNING=1 to silence this message. (Background on SQLAlchemy 2.0 at: https://sqlalche.me/e/b8d9)
    connection.execute("SELECT 1")

Updating appmap-python to run SQLAlchemy = "^2" will cause the tests to fail.

https://gist.github.com/petecheslock/a79c1be270cbe5e65fcc93a4ca498a72

@apotterri

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants