Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Alphabetize, check uniqueness #16

Open
gshotwell opened this issue Nov 20, 2023 · 2 comments
Open

Alphabetize, check uniqueness #16

gshotwell opened this issue Nov 20, 2023 · 2 comments

Comments

@gshotwell
Copy link

The docs.jsonl is a bit hard to navigate, it might be a good idea to alphabetize the JSON and add a CI job which checks alphabetization and name uniqueness.

@ignacio-chiazzo
Copy link

I opened a PR for this #76

@unixwzrd
Copy link

unixwzrd commented Feb 8, 2025

I think this might be better for CI/CD pipeline and locally, - see PR #85

  • Runs pre-commit checks automatically on both:
    • Local commits (through git hooks)
    • GitHub Actions (on PRs and pushes)
  • Runs on local repository clones without requiring Python/pre-commit package
  • Sorts entries by name (case-insensitive)
  • Deduplicates URLs automatically and reports removed duplicates to STDERR
  • Reports case-insensitive duplicate Names to STDERR (but keeps them)
  • All logs may be easily read and action taken on them.
  • Allows commits to proceed even with warnings
  • Easy setup:
    • GitHub Actions workflow runs automatically
    • Local setup needs just 3 commands (see README)

The script is stored in .github/scripts/ following GitHub best practices and uses pure bash/awk for maximum compatibility.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants