-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Raising missing events #1741 #1750
Conversation
Signed-off-by: BugDiver <vinaysh@thoughtworks.com>
@BugDiver Thank you for contributing to gauge. Your pull request has been labeled as a release candidate 🎉🎉. Merging this PR will trigger a release. Please bump up the version as part of this PR.Instructions to bump the version can found at CONTRIBUTING.md If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done. |
Benchmark Results
Notes
See Workflow log for more details. |
runner1 := &fakeGrpcRunner{messageCount: make(map[gauge_messages.Message_MessageType]int)} | ||
runner2 := &fakeGrpcRunner{messageCount: make(map[gauge_messages.Message_MessageType]int)} | ||
e := parallelExecution{ | ||
numberOfExecutionStreams: 5, | ||
specCollection: gauge.NewSpecCollection(specs, false), | ||
runners: []runner.Runner{runner1, runner2}, | ||
pluginHandler: &mockPluginHandler{NotifyPluginsfunc: func(m *gauge_messages.Message) {}}, | ||
pluginHandler: &mockPluginHandler{NotifyPluginsfunc: func(m *gauge_messages.Message) { | ||
recievedMesseges = append(recievedMesseges, m) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo in variable name
@@ -19,16 +19,20 @@ import ( | |||
|
|||
func TestSuiteHooksAreExecutedOncePerRun(t *testing.T) { | |||
specs := createSpecsList(6) | |||
var recievedMesseges []*gauge_messages.Message |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo in variable name
fixes #1741