Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Raising missing events #1741 #1750

Merged
merged 3 commits into from
Sep 10, 2020
Merged

Raising missing events #1741 #1750

merged 3 commits into from
Sep 10, 2020

Conversation

BugDiver
Copy link
Member

@BugDiver BugDiver commented Sep 9, 2020

fixes #1741

Signed-off-by: BugDiver <vinaysh@thoughtworks.com>
@gaugebot gaugebot bot requested a review from sriv September 9, 2020 08:36
@gaugebot
Copy link

gaugebot bot commented Sep 9, 2020

@BugDiver Thank you for contributing to gauge. Your pull request has been labeled as a release candidate 🎉🎉.

Merging this PR will trigger a release.

Please bump up the version as part of this PR.

Instructions to bump the version can found at CONTRIBUTING.md

If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done.

@BugDiver BugDiver added the bug label Sep 9, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2020

Benchmark Results

java_maven_multithreaded.csv

Commit CPU Memory Time ExitCode
6e0d83f 183% 355184 0:23.08 0
c532320 183% 303728 0:22.61 0
c93f7af 153% 362648 0:37.51 0
e8948af 175% 335984 0:23.92 0

java_simple_parallel.csv

Commit CPU Memory Time ExitCode
6e0d83f 185% 316576 0:20.36 0
c532320 188% 316540 0:20.17 0
c93f7af 182% 324672 0:20.33 0
e8948af 179% 285040 0:22.71 0

java_gradle_multithreaded.csv

Commit CPU Memory Time ExitCode
6e0d83f 180% 376804 0:18.33 0
c532320 182% 355644 0:20.04 0
c93f7af 179% 558492 0:33.83 0
e8948af 181% 581072 0:28.47 0

java_gradle_parallel.csv

Commit CPU Memory Time ExitCode
6e0d83f 178% 394976 0:20.54 0
c532320 178% 374068 0:20.26 0
c93f7af 166% 639544 0:30.80 0
e8948af 186% 577796 0:34.61 0

java_simple_serial.csv

Commit CPU Memory Time ExitCode
6e0d83f 179% 351068 0:13.29 0
c532320 170% 343216 0:14.42 0
c93f7af 163% 341344 0:15.11 0
e8948af 168% 319880 0:12.80 0

java_maven_serial.csv

Commit CPU Memory Time ExitCode
6e0d83f 181% 318024 0:17.65 0
c532320 181% 338348 0:18.11 0
c93f7af 147% 296200 0:30.25 0
e8948af 176% 308140 0:25.61 0

java_maven_parallel.csv

Commit CPU Memory Time ExitCode
6e0d83f 184% 318832 0:21.98 0
c532320 184% 340820 0:20.92 0
c93f7af 158% 341744 0:31.93 0
e8948af 162% 344920 0:27.10 0

java_simple_multithreaded.csv

Commit CPU Memory Time ExitCode
6e0d83f 181% 397856 0:13.15 0
c532320 174% 384524 0:13.73 0
c93f7af 174% 385536 0:14.13 0
e8948af 169% 361160 0:14.33 0

java_gradle_serial.csv

Commit CPU Memory Time ExitCode
6e0d83f 179% 388428 0:21.85 0
c532320 177% 349640 0:21.11 0
c93f7af 166% 619168 0:33.39 0
e8948af 184% 565444 0:37.65 0

Notes

  • The results above are generated by running against seed projects in https://github.com/getgauge/gauge-benchmark
  • These results are not persisted, but on merging to master the benchmark will be rerun.
  • These benchmark are run in Github Actions' agents, which are virtualized. Results are not to be taken as actual benchmarks.Rather, these are indicative numbers and make sense for comparison.

See Workflow log for more details.

runner1 := &fakeGrpcRunner{messageCount: make(map[gauge_messages.Message_MessageType]int)}
runner2 := &fakeGrpcRunner{messageCount: make(map[gauge_messages.Message_MessageType]int)}
e := parallelExecution{
numberOfExecutionStreams: 5,
specCollection: gauge.NewSpecCollection(specs, false),
runners: []runner.Runner{runner1, runner2},
pluginHandler: &mockPluginHandler{NotifyPluginsfunc: func(m *gauge_messages.Message) {}},
pluginHandler: &mockPluginHandler{NotifyPluginsfunc: func(m *gauge_messages.Message) {
recievedMesseges = append(recievedMesseges, m)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in variable name

@@ -19,16 +19,20 @@ import (

func TestSuiteHooksAreExecutedOncePerRun(t *testing.T) {
specs := createSpecsList(6)
var recievedMesseges []*gauge_messages.Message
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in variable name

Signed-off-by: BugDiver <vinaysh@thoughtworks.com>
@sriv sriv merged commit c982558 into master Sep 10, 2020
@sriv sriv deleted the missing-events branch September 10, 2020 12:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Development

Successfully merging this pull request may close these issues.

Inconsistency of raising ExecutionStartingRequest event for grpc plugins if running specs in parallel
2 participants