Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Don't print a trailing space on steps with table args #1790

Merged
merged 4 commits into from
Nov 30, 2020

Conversation

camjackson
Copy link
Contributor

Fixes #1787 🙂

Signed-off-by: Cam Jackson <camjackson89@gmail.com>
@camjackson
Copy link
Contributor Author

Not sure what those failures about, from the logs it doesn't look like any tests or linter rules are actually failing?

@sriv
Copy link
Member

sriv commented Nov 22, 2020

@camjackson - I will take a look at this PR.

I am currently looking at a fix for #318 and I want to wrap that before I look at this, I assume there could be some overlap.

@sriv sriv self-assigned this Nov 22, 2020
@zabil zabil merged commit 5d79a6e into getgauge:master Nov 30, 2020
@camjackson
Copy link
Contributor Author

Thanks for approving and merging, @sriv and @zabil! When can we expect to see a new version of the extension published with this change?

@sriv
Copy link
Member

sriv commented Dec 7, 2020

Hey @camjackson - gauge 1.1.6 is out and it includes this change -https://github.com/getgauge/gauge/releases/tag/v1.1.6

Thanks again for the contrib!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Formatter adds trailing whitespace to steps that have table data
3 participants