Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Send ConceptEnd notification when concept step fails #2461

Merged

Conversation

PiotrNestor
Copy link
Contributor

Send ConceptEnd notification (NotifyConceptExecutionEnding) when a concept step fails and the concept is then finishing.

Other reasons for this update:

  • consistency - ConceptEnd is sent when a concept finishes both successfully and when a concept step fails
  • ConceptEnd must be sent on concept step failure when there are Scenario Teardown steps. Without this notification the teardown steps are perceived to be part of the concept which is not correct

…is finishing

Signed-off-by: Piotr Nestorow <piotr.nestorow@systemverification.com>
Copy link
Contributor

github-actions bot commented Feb 2, 2024

Benchmark Results

java_maven_serial.csv

Commit CPU Memory Time ExitCode
9b96118 40% 201760 0:33.93 0
62b9937 80% 269976 0:17.24 0
b55b734 84% 216004 0:16.96 0
b5be133 73% 242992 0:19.95 0

java_gradle_multithreaded.csv

Commit CPU Memory Time ExitCode
9b96118 6% 120580 0:36.40 0
62b9937 10% 120752 0:23.40 0
b55b734 10% 108120 0:23.65 0
b5be133 10% 113816 0:22.24 0

java_maven_multithreaded.csv

Commit CPU Memory Time ExitCode
9b96118 41% 178280 0:29.67 0
62b9937 77% 234160 0:14.59 0
b55b734 67% 234752 0:16.79 0
b5be133 70% 237432 0:16.25 0

java_maven_parallel.csv

Commit CPU Memory Time ExitCode
9b96118 36% 193468 0:31.56 0
62b9937 41% 246160 0:33.10 0
b55b734 43% 231220 0:31.14 0
b5be133 43% 234948 0:31.57 0

java_gradle_parallel.csv

Commit CPU Memory Time ExitCode
9b96118 5% 124252 0:39.01 0
62b9937 6% 119752 0:41.56 0
b55b734 5% 115740 0:40.07 0
b5be133 6% 116952 0:42.16 0

java_simple_multithreaded.csv

Commit CPU Memory Time ExitCode
9b96118 24% 63564 0:14.41 0
62b9937 36% 70008 0:09.92 0
b55b734 38% 67900 0:09.27 0
b5be133 25% 68360 0:14.14 0

java_simple_serial.csv

Commit CPU Memory Time ExitCode
9b96118 25% 63568 0:16.12 0
62b9937 42% 65868 0:14.17 0
b55b734 52% 66024 0:11.35 0
b5be133 44% 65820 0:13.36 0

java_simple_parallel.csv

Commit CPU Memory Time ExitCode
9b96118 20% 65668 0:27.20 0
62b9937 21% 72096 0:25.94 0
b55b734 24% 72212 0:22.78 0
b5be133 22% 70304 0:25.56 0

java_gradle_serial.csv

Commit CPU Memory Time ExitCode
9b96118 6% 96004 0:42.09 0
62b9937 9% 106932 0:24.90 0
b55b734 9% 118740 0:25.15 0
b5be133 9% 114648 0:25.17 0

Notes

  • The results above are generated by running against seed projects in https://github.com/getgauge/gauge-benchmark
  • These results are not persisted, but on merging to master the benchmark will be rerun.
  • These benchmark are run in Github Actions' agents, which are virtualized. Results are not to be taken as actual benchmarks.Rather, these are indicative numbers and make sense for comparison.

See Workflow log for more details.

@gaugebot
Copy link

gaugebot bot commented Feb 2, 2024

@PiotrNestor Thank you for contributing to gauge. Your pull request has been labeled as a release candidate 🎉🎉.

Merging this PR will trigger a release.

Please bump up the version as part of this PR.

Instructions to bump the version can found at CONTRIBUTING.md

If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done.

@sriv sriv merged commit 6475093 into getgauge:master Feb 2, 2024
30 checks passed
@PiotrNestor PiotrNestor deleted the concept-end-notify-on-step-error branch February 5, 2024 09:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Development

Successfully merging this pull request may close these issues.

2 participants