From 544b2761a07b74c90c1599473da3beb73a7c23af Mon Sep 17 00:00:00 2001 From: Marek Maj Date: Fri, 7 Jun 2024 18:23:43 +0200 Subject: [PATCH 1/2] Reinstatiate javadoc step in common build --- .github/workflows/build.yml | 2 +- .../connectors/http/HttpPostRequestCallbackFactory.java | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index ee58d8e0..b19041f5 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -38,7 +38,7 @@ jobs: - name: Test JavaDoc run: mvn $MAVEN_CLI_OPTS $JAVA_ADDITIONAL_OPTS javadoc:javadoc - if: startsWith(matrix.flink, '1.15.0') + if: startsWith(matrix.flink, '1.18') - name: Add coverage to PR id: jacoco diff --git a/src/main/java/com/getindata/connectors/http/HttpPostRequestCallbackFactory.java b/src/main/java/com/getindata/connectors/http/HttpPostRequestCallbackFactory.java index c4b3e5a0..8f66e32a 100644 --- a/src/main/java/com/getindata/connectors/http/HttpPostRequestCallbackFactory.java +++ b/src/main/java/com/getindata/connectors/http/HttpPostRequestCallbackFactory.java @@ -13,6 +13,7 @@ * other factories in *
resources/META-INF/services/org.apache.flink.table.factories.Factory
* file and then referenced by their identifiers in: + * *
* *

The following example shows the minimum Table API example to create a {@link HttpDynamicSink} From f28a4119479540e911ef7e360069305d7eb43f05 Mon Sep 17 00:00:00 2001 From: Marek Maj Date: Fri, 7 Jun 2024 18:34:23 +0200 Subject: [PATCH 2/2] Fix
tag for javadoc --- .../http/HttpPostRequestCallbackFactory.java | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/main/java/com/getindata/connectors/http/HttpPostRequestCallbackFactory.java b/src/main/java/com/getindata/connectors/http/HttpPostRequestCallbackFactory.java index 8f66e32a..7e722c20 100644 --- a/src/main/java/com/getindata/connectors/http/HttpPostRequestCallbackFactory.java +++ b/src/main/java/com/getindata/connectors/http/HttpPostRequestCallbackFactory.java @@ -14,16 +14,16 @@ *

resources/META-INF/services/org.apache.flink.table.factories.Factory
* file and then referenced by their identifiers in: * - *
+ *
* *

The following example shows the minimum Table API example to create a {@link HttpDynamicSink} * that uses a custom callback created by a factory that returns my-callback as its