Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

k-table: fix sortable rows #6609

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

distantnative
Copy link
Member

@distantnative distantnative commented Aug 11, 2024

Description

Summary of changes

  • Table sections: Only allow sorting rows that are sortable.
  • Previously, the rows itself weren't sortable as the sort handle was hidden, but other sortable rows could be moved above/below/in-between unsortable rows.
  • This PR aligns the behavior/code with how it's done for the other layouts (with k-items)

Changelog

Fixes

  • Sections with table layout: fixed some issues with sorting rows that should be unsortable

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add lab and/or sandbox examples (wherever helpful)
  • Add changes & docs to release notes draft in Notion

@distantnative distantnative added the type: bug 🐛 Is a bug; fixes a bug label Aug 11, 2024
@distantnative distantnative self-assigned this Aug 11, 2024
@distantnative distantnative marked this pull request as ready for review August 11, 2024 19:10
@distantnative distantnative requested a review from a team August 11, 2024 19:10
@distantnative distantnative added this to the 4.4.0 milestone Aug 11, 2024
@bastianallgeier bastianallgeier merged commit efa1606 into develop-minor Aug 12, 2024
4 checks passed
@bastianallgeier bastianallgeier deleted the fix/6595-table-sortable-rows branch August 12, 2024 08:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
type: bug 🐛 Is a bug; fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sorting doesn't work as expected if some pages have fixed nums
2 participants