Android releases now build directly in android-lantern #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxtoacart
commented
Jun 7, 2021
oxtoacart
commented
Jun 7, 2021
oxtoacart
commented
Jun 7, 2021
oxtoacart
commented
Jun 7, 2021
oxtoacart
commented
Jun 7, 2021
android/app/src/main/java/org/getlantern/lantern/vpn/LanternVpnService.java
Show resolved
Hide resolved
atavism
reviewed
Jun 8, 2021
| @@ -13,6 +13,10 @@ This project uses some shared code from a submodule that needs to be initialized | |||
|
|
|||
| `git submodule update --init` | |||
|
|
|||
| ## Protocol Buffers | |||
| If you update the protocol buffer definitions in protos_shared, make sure to run `make protos` to | |||
| update the generated dart code. | |||
There was a problem hiding this comment.
It's not necessary for this PR, but could you also just have Make itself rebuild the generated dart code whenever it detects any of the protocol definition files in protos_shared have changed (while building Lantern)? Then we wouldn't have to remember to run this?
There was a problem hiding this comment.
I'll make the debug APK depend on that. I think release shouldn't, because that could cause us to use different compiled protos in release than what we tested with. Does that sound good?
There was a problem hiding this comment.
Yep sounds great! Thanks, @oxtoacart
|
@atavism Are you okay with me merging this or is there still some other stuff you want to look at? |
|
Fine to merge, @oxtoacart! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For getlantern/lantern-internal#4878.
Depends on getlantern/flashlight#1110