Fix for updating disappearing message settings plus a couple of drive-by fixes #138
Conversation
| call.argument("displayName")!! | ||
| ) | ||
| "setDisappearSettings" -> messaging.setDisappearSettings( | ||
| call.argument<String>("contactId")!!.directContactPath, |
There was a problem hiding this comment.
This is the actual fix, we have to pass the direct contact path.
| attachments = call.argument<List<ByteArray>>("attachments")?.map { Model.StoredAttachment.parseFrom(it) }?.toTypedArray(), | ||
| replyToId = call.argument("replyToId"), | ||
| replyToSenderId = call.argument("replyToSenderId")) | ||
| call.argument("identityKey")!!, |
| @@ -502,10 +498,11 @@ class _ConversationState extends State<Conversation> | |||
| // TODO: generalize in theme | |||
| showRecentsTab: true, | |||
| recentsLimit: 28, | |||
| noRecentsText: 'No Recents', | |||
| noRecentsStyle: TextStyle(fontSize: 16, color: Colors.black26), | |||
| noRecentsText: 'No Recents'.i18n, | |||
| // TODO: generalize in theme | ||
| categoryIcons: CategoryIcons(), | ||
| categoryIcons: const CategoryIcons(), |
There was a problem hiding this comment.
This and some of the other const declarations are linter fixes.
| @@ -6,7 +6,6 @@ import 'package:focused_menu/modals.dart'; | |||
|
|
|||
| import 'package:lantern/messaging/messaging_model.dart'; | |||
| import 'package:lantern/messaging/widgets/message_utils.dart'; | |||
| import 'package:lantern/ui/widgets/copied_text_widget.dart'; | |||
There was a problem hiding this comment.
btw I haven't deleted that widget yet since I'm not sure where we will land with the message actions popup UX.
| @@ -254,7 +251,6 @@ class _ConversationState extends State<Conversation> | |||
| _send(_newMessage.value.text, | |||
| replyToSenderId: _quotedMessage?.senderId, | |||
| replyToId: _quotedMessage?.id); | |||
| dismissKeyboard(); | |||
There was a problem hiding this comment.
This was redundant with the dismissKeyboard() inside _send.
| @@ -110,7 +108,6 @@ class _ConversationState extends State<Conversation> | |||
| replyToId: replyToId, | |||
| replyToSenderId: replyToSenderId, | |||
| ); | |||
| dismissKeyboard(); | |||
There was a problem hiding this comment.
When conversing with someone, I was annoyed by having to always re-focus on the message field to bring up the keyboard again. I think it's a more normal experience for the keyboard to just remain open so that you can keep firing off messages, so I took this out. @Kallirroi @Derekf5 please chime in if you disagree :)
There was a problem hiding this comment.
To be precise, the text messaging app that I use and Signal both keep the text field focused and the keyboard open after sending a message.
There was a problem hiding this comment.
agreed! the keyboard should remain open after sending messages until the user actively dismisses it by hitting the native close keyboard button or clicking in the message window above the keyboard.
There was a problem hiding this comment.
Sounds good to me - I might open a ticket specifically for nailing down the keyboard UX, as I think there's a few other glitches as well.
Did you stop and recompile the app from scratch? The change was on the Kotlin side. |
I don't see an update? |
Sorry - I ran into a pretty substantial |
Closes getlantern/engineering#623.