Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[4656] Update Android UI to reflect new data cap models #20

Merged
merged 7 commits into from
Jan 14, 2021

Conversation

markhor-sarwar
Copy link

@markhor-sarwar markhor-sarwar self-assigned this Jan 11, 2021
@markhor-sarwar markhor-sarwar marked this pull request as draft January 11, 2021 10:58
@markhor-sarwar
Copy link
Author

@oxtoacart I marked this PR as draft because I'm waiting for these PRs to get merged before I pulled those changes into this PR:

I also need to update the translations as well.

@myleshorton
Copy link
Contributor

Doesn't this still need to update bandwidthUpdate in LanternSessionManager?

@myleshorton
Copy link
Contributor

Unfortunately in its current state lantern mobile doesn't build.

@myleshorton myleshorton marked this pull request as ready for review January 12, 2021 03:49
@myleshorton myleshorton marked this pull request as draft January 12, 2021 03:49
@oxtoacart
Copy link

I tested this on my Samsung Galaxy S10e running Android 9. The notification showed up okay, but there's some issues with the display on the main screen.

  1. When I have partial data usage, the progress bar is complete blank, but once I hit 100% it's completely full. Looks like maybe the in-between values aren't being rendered right.
  2. On the data usage tab, the progress bar is empty even when I'm at 100% data usage
  3. The formatting of the text next to the Upgrade button isn't great. Putting the "Resets At" message on a separate line would help

image

image

image

@markhor-sarwar
Copy link
Author

markhor-sarwar commented Jan 13, 2021

  • I have updated the text formatting to put Reset At into a separate line.
  • I also updated the Upgrade to Pro for unlimited data... text to have exactly the same text style with the above (it previously a little bit smaller, and not fully left aligned, which doesn't look really good).

Screenshot_20210113-152657.png

@markhor-sarwar
Copy link
Author

markhor-sarwar commented Jan 13, 2021

For testing different bandwidth updates, I added this block of code, so I can change the values to whatever I want.
Just to confirm, the percent is the used percent, not remaining percent right?

Screenshot 2021-01-13 at 3 52 15 PM

As far as I'm testing, the app is showing the progress correctly. I couldn't reproduce the issue. Btw, I don't think this PR introduces those issues, so if we want to push out a new build, I think we can create separate tickets to address the issues and merge this PR.

Screenshot_20210113-155437.png

Screenshot_20210113-155445.png

Screenshot_20210113-155520.png

Screenshot_20210113-155547.png

@oxtoacart
Copy link

I found a few issues with this. They're addressed in #21. With that PR (and removing convertTTSToDateTimeString from mobilesdk), this PR is good to merge.

Freeze bandwidth at point in time, display in correct time zone and u…
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants