- Fixed NoClassDefFoundError: FinestWebview need guava #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myleshorton
approved these changes
Feb 11, 2021
|
Pulling this in! Will rebuild. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: getlantern/engineering#575
As our FinestWebview AAR was added manually, so we need to re-declare the dependencies in our app module. And during the process to reduce apk size, it appeared as unused then was removed as a result. I add it back under the FinestWebView dependencies section to make sure that we won't remove it again in future.
Also, by adding back this one, the apk size will increase about 600kb.