Crdzbird/conversation messaging scaffold hi fi #354
Conversation
- Removed static title to have a more flexible widget title, this was needed to have a clean approach to the HiFi design on Figma
lib/messaging/introduce.dart
Outdated
| @@ -26,7 +26,10 @@ class _IntroduceState extends State<Introduce> { | |||
| Widget build(BuildContext context) { | |||
| var model = context.watch<MessagingModel>(); | |||
| return BaseScreen( | |||
| title: 'Introduce Contacts (${selectedContactIds.length})'.i18n, | |||
There was a problem hiding this comment.
Almost all of the other files just have one change and that is on the title param which now requires a Widget instead of a String
lib/messaging/messages.dart
Outdated
| title: 'Messages'.i18n, | ||
| title: Text( | ||
| 'Messages'.i18n, | ||
| style: tsTitleAppbar, |
There was a problem hiding this comment.
I don't love that this repeats. Maybe BaseScreen can have two parameters, String titleText and Widget title. Then we can just have the styling for the titleText inside of BaseScreen. What do you think @Crdzbird ?
There was a problem hiding this comment.
Sure, we can have a dynamic param instead, and just based on the type we can set a default widget.
| title: title, | ||
| logoTitle: logoTitle, | ||
| appBar: AppBar( | ||
| title: title.runtimeType == String |
There was a problem hiding this comment.
Instead of 2 params, we can just use one dynamic param and based on his type set a default widget.
There was a problem hiding this comment.
If the second param is an absolute must, I can add it instead of the dynamic @oxtoacart
…lantern into crdzbird/conversation_messaging_scaffold_HiFi
|
Thanks @oxtoacart! |
This PR is to setup the Scaffold construction for the Messaging UI.
I have to update the
base_screen.dartto have more flexibility with the components that are gonna be to be displayed.