-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Various fixes after group testing #381
Conversation
@ox I experimented/tested on my phones and updated things a little in 2f2b7e0. Still, pretty hacky obviously. Looks like triggering the native emoji keyboard is hard, as is getting a measurement of the native keyboard height from Flutter (so that we can size them equally). Let me know how it looks on your phone? What I'm more worried about is just how laggy using it is, does not make up for smooth UX unfortunately. Maybe we can ticket something in the backlog for iterating on it? SVID_20210915_142426_1.mp4 |
Merging and will fix eventual problems on `kr/testing_bugs_fixes` branch
In release builds the Emoji keyboard doesn't seem too laggy to me. Is yours slow even on the release build from Slack @Kallirroi ? |
…ze as the keyboard
…-lantern into kr/testing_bugs_fixes
…-lantern into kr/testing_bugs_fixes
…-lantern into kr/testing_bugs_fixes
…rent overflow type
…-lantern into kr/testing_bugs_fixes
Nice work @Kallirroi ! |
Closes getlantern/engineering#946 getlantern/engineering#948 getlantern/engineering#691 getlantern/engineering#685 getlantern/engineering#688 and fixes strings in
en.po
here and there.SVID_20210914_113529_1.mp4
'my_message_key'.i18n
and are defined inen.po
.colors.dart
and are not duplicatedtext_styles.dart
and are not duplicated