Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Message request, completed chatNumber addition, completed recovery #506

Merged
merged 55 commits into from
Nov 16, 2021
Merged

Message request, completed chatNumber addition, completed recovery #506

merged 55 commits into from
Nov 16, 2021

Conversation

cosmicespresso
Copy link

@cosmicespresso cosmicespresso commented Nov 12, 2021 •
edited
Loading

  • All strings are defined using localized message keys like 'my_message_key'.i18n and are defined in en.po.
  • All colors are defined using Hex (not using built-in colors), are defined in colors.dart and are not duplicated
  • All text styles are defined in text_styles.dart and are not duplicated
  • All icons are using the vector resource from Figma (do not use built-in Icons)
  • Repeated code has been factored into custom widgets
  • Layout looks good in both LTR (English) and RTL (Persian) languages
  • If you refactored existing code, have you tested the refactored functionality against the old version to make sure you didn't break anything?
  • Do the tests pass? Consistently?
  • Did this change improve test coverage?
  • Is the code in question being linted? If not, consider adding a linter step to CI. If yes, make sure the linter is happy.
  • Have you logged tickets for related technical debt with the label “techdebt”?

oxtoacart
oxtoacart reviewed Nov 12, 2021
View reviewed changes
Base automatically changed from kr/onboarding to ox/messaging November 12, 2021 21:07
oxtoacart
oxtoacart reviewed Nov 15, 2021
View reviewed changes
android/app/src/main/kotlin/io/lantern/android/model/MessagingModel.kt
"saveNotificationsTS" -> {
val ts = System.currentTimeMillis()
db.mutate { tx ->
tx.put("/requestNotificationLastDismissed", ts)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of mixedCase :)

@oxtoacart oxtoacart mentioned this pull request Nov 15, 2021
Merged
oxtoacart and others added 19 commits November 15, 2021 15:33
@oxtoacart
Merge branch 'kr/requests_chatNumberAdd' into ox/requests
c66436e
@oxtoacart
Copy recovery key actually copies recovery key
f4c492d
@cosmicespresso
tiny fix
4125cf7
@cosmicespresso
use withoutWhitespace
9a79bb0
@oxtoacart
Fixed whitespace removal DRY violation
08f7497
@oxtoacart
Merge branch 'kr/requests_chatNumberAdd' into ox/requests
a08d853
@cosmicespresso
and in model.recover()
36dad4a
@oxtoacart
Updated to latest messaging-android
2b1dabb
@cosmicespresso
hide dev button
3932930
@oxtoacart
Check for empty subtitles
3b4c4c1
@oxtoacart
Copy formatted chat numbers to clipboard
8d3d409
@cosmicespresso
hide text editing field in Contact Info when contact.isMe == true
e70b3f4
@cosmicespresso
Merge branch 'ox/requests' of github.com:getlantern/android-lantern i…
72cefef 
…nto ox/requests
@oxtoacart
Various fixes
e890411
@oxtoacart
Merge branch 'ox/requests' of github.com:getlantern/android-lantern i…
a0490b8 
…nto ox/requests
@oxtoacart
Fixed location of Add New Contact header
c612063
@oxtoacart
Fixed name dialog dismissal
d94819a
@cosmicespresso
drive by
c5e9446
@cosmicespresso
Merge pull request #510 from getlantern/ox/requests
ca6f40f 
Code review feedback
@cosmicespresso cosmicespresso merged commit 1107407 into ox/messaging Nov 16, 2021
@cosmicespresso cosmicespresso deleted the kr/requests_chatNumberAdd branch November 16, 2021 16:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@oxtoacart oxtoacart oxtoacart left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cosmicespresso @oxtoacart