Nov 18 build fixes #554
Merged
Nov 18 build fixes #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxtoacart
reviewed
Nov 19, 2021
| if (this < 60) { | ||
| return toString() + (longForm ? ' seconds' : 's'); // TODO: add i18n | ||
| return longForm | ||
| ? 'longform_seconds'.i18n.fill([toString()]) |
oxtoacart
reviewed
Nov 19, 2021
| /// Based on https://www.flutterclutter.dev/flutter/tutorials/date-format-dynamic-string-depending-on-how-long-ago/2020/229/ | ||
| extension Humanize on int { | ||
| String humanizeSeconds({bool longForm = false}) { | ||
| //seconds | ||
| var result; |
There was a problem hiding this comment.
This class is one of the few that actually has a working unit test. Can you please update the unit test to match your changes?
|
LGTM! The only things I found (and fixed) were:
|
|
Oh, and of course the unit test still needs to be updated, but then this can be merged. |
|
Test passes, LGTM! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
humanizeSeconds()