Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Merge replica-mobile feature to ox/messaging #641

Merged
merged 101 commits into from
Dec 21, 2021
Merged

Merge replica-mobile feature to ox/messaging #641

merged 101 commits into from
Dec 21, 2021

Conversation

oxtoacart
Copy link

  • All strings are defined using localized message keys like 'my_message_key'.i18n and are defined in en.po.
  • All colors are defined using Hex (not using built-in colors), are defined in colors.dart and are not duplicated
  • All text styles are defined in text_styles.dart and are not duplicated
  • All icons are using the vector resource from Figma (do not use built-in Icons)
  • Repeated code has been factored into custom widgets
  • Layout looks good in both LTR (English) and RTL (Persian) languages
  • If you refactored existing code, have you tested the refactored functionality against the old version to make sure you didn't break anything?
  • Do the tests pass? Consistently?
  • Did this change improve test coverage?
  • Is the code in question being linted? If not, consider adding a linter step to CI. If yes, make sure the linter is happy.
  • Have you logged tickets for related technical debt with the label “techdebt”?

soltzen added 30 commits December 14, 2021 09:40
@soltzen
[cmake|gradle] Force add libc++_shared.so
3057691
@soltzen
[test] Comment-out upgradeBtn error
26f83b9 
That button doesn't exist
@soltzen
[makefile] Add GOPRIVATE and correct make target
e6881b3
@soltzen
[dotfiles] Ignores .cxx dir
9a41b9e
@soltzen
[internalsdk] Add new Replica settings
dc9b76e
@soltzen
[internalsdk] Add replica init code
090d1a2
@soltzen
[go.mod] go mod tidy
6991122 
Also, synchronise the flashlight version with lantern-desktop as of https://github.com/getlantern/lantern-desktop/commit/a80e82fdd9f03f1c952e952f732f465676902357
@soltzen
[test] Add testReplicaIsInitialized()
3ef7898
@soltzen
[readme] Fix broken links and cleanup markdown
f4f5a73
@soltzen
[readme] Add feature section
2040777
@soltzen
[make] Strip symbols when building production
d5a6630
@soltzen
[readme] Add replica-mobile label comment
759e866
@soltzen
Update README.md
4627e1a
@soltzen
[settings] Enable Replica
ec080b1
@soltzen
[replica|backend] Set a dynamic replica port
c5da7b9 
And send it from replica -> backend through MethodChannels (in ReplicaModel.kt and replica_model.dart)
@soltzen
[scripts] Add run_avd.rb
7324740
@soltzen
[replica] Add replica video view and markdown link builder
08f3ddb
@soltzen
[routes] Update routes to include ReplicaVideoPlayerScreen
f6e4fd9
@soltzen
[pubspec] Add markdown and logger
619fb44
@soltzen
[ui:replica] Add ReplicaLink
b4eb5e1
@soltzen
[messaging] Detect replica links
93901da
@soltzen
[build.gradle] Match test deps with each other
0d47177
@soltzen
[gomod] Update
0bb6843
@soltzen
[ui:replica] Add ReplicaApi
9393e95
@soltzen
[ui:replica] Add LinkOpenerScreen and UnknownScreen
9d72c18
@soltzen
[replica] Add replica video view and markdown link builder
0a64d8f
@soltzen
[go.mod] go mod tidy
eaa8d92
@soltzen
[pubspec] Add new dependencies
f13ee1a
@soltzen
[messaging] Abstract notifications
b431be6 
So, it can be used by other classes
@soltzen
[backend|replica|ui] Pass replicaPort to UI through SharedPrefs
d95f677
soltzen and others added 24 commits December 17, 2021 12:48
@soltzen
[ui] Update routes
b7a9253
@soltzen
[liblantern] Update
2e1edb1
@soltzen
[backend:replica] Fix bug when calling MethodChannels
8470f16
@oxtoacart
Selectively enable Replica based on global config and geolocation
f1b848a
@soltzen
[liblantern] Update
1597ae6
@soltzen
[ui] Update localizations
be99c55
@soltzen
[ui] Add missing assets
1579e6a
@soltzen
[pubspec] Add video_thumbnail and mime
6af2053
@soltzen
[ui] Fix missing design specs
fe8de75 
As mentioned here https://github.com/getlantern/lantern-internal/issues/5131#issuecomment-996857327
This is mostly UI fixes, apart from the 'mimeTypes' parameter changes in logic/api.dart
@soltzen
[ui:localization] Load localizations once only
5b7efb5 
Taken verbatim from Ox's amazing work here https://github.com/getlantern/android-lantern/pull/643/files#diff-d904ef49182994a0faacb5b62d1adb0a702790c97c59b87d92c8cc24778f0261R62.
@oxtoacart
Removed unused imports and fixed corners on Replica search field icon
5fd370d
@oxtoacart
Vertically centered empty state icon on replica search results
5586480
@oxtoacart
Don't show list item divider when Replica focused menu is open
a2692fd
@oxtoacart
Created reusable search field based on CTextField
3bdb67c
@oxtoacart
Merge pull request #643 from getlantern/ox/replicafeatureenabled
5017ca7 
Selectively enable Replica based on global config and geolocation
@oxtoacart
Merged from upstream
7049e38
@oxtoacart
Use TextEditingController.clear() instead of text = ''
85631b3
@oxtoacart
Post merge fixes
e84c546
@oxtoacart
Use ReplicaLink.displayName for search results
54e2c79
@oxtoacart
Using localhost instead of 127.0.0.1 to avoid 'Cleartext HTTP traffic…
f0f9775 
… to 127.0.0.1 not permitted' on Android 9+
@oxtoacart
Removed Replica share actions
78933b7
@oxtoacart
Hide video player controls while video is playing
3724105
@oxtoacart
Merge pull request #644 from getlantern/soltzen/li5131_design_review
8c813fa 
[replica] Add missing design specs
@oxtoacart
Merged from ox/messaging
7f9b5ca
@oxtoacart oxtoacart changed the title Don't merge yet - Soltzen/feat replica mobile Soltzen/feat replica mobile Dec 21, 2021
@oxtoacart
Copy link
Author

Monumental work @soltzen !

@oxtoacart oxtoacart merged commit 57c44ad into ox/messaging Dec 21, 2021
@oxtoacart oxtoacart deleted the soltzen/feat__replica-mobile branch December 21, 2021 20:35
@soltzen soltzen changed the title Soltzen/feat replica mobile Merge replica-mobile feature to ox/messaging Jan 3, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oxtoacart @soltzen