[internalsdk:replica] Remove root route handler #720
Conversation
It was there for serp_web searches, but we don't use that. Furthermore, it caused a major recursion issue. See here: https://github.com/getlantern/android-lantern/issues/719
|
I'm gonna go ahead and merge this. @oxtoacart Still would like the review, please |
| @@ -28,7 +28,7 @@ Note - you might see an error like `Can't load Kernel binary: Invalid SDK hash.` | |||
|
|
|||
| All those dependencies must be in your PATH | |||
|
|
|||
| * Java 11 or greater | |||
| * Java 8 or greater (for Android to work) | |||
There was a problem hiding this comment.
Why did you change this back to 8? I intentionally changed it to 11 in this PR.
There was a problem hiding this comment.
When I build android-release with Java 8, it fails with the below error, so we definitely can't use Java 8.
* What went wrong:
Execution failed for task ':app:kaptProdReleaseKotlin'.
> A failure occurred while executing org.jetbrains.kotlin.gradle.internal.KaptWithoutKotlincTask$KaptExecutionWorkAction
> java.lang.reflect.InvocationTargetException (no error message)
There was a problem hiding this comment.
Since this was just merged, I'll fix in main.
There was a problem hiding this comment.
Why did you change this back to 8? I intentionally changed it to 11 in this PR.
Android's sdkmanager and avdmanager require Java 8. I just reproduced your error when running it with 8, and reproduced mine when running either of those binaries with 11... That's not fun.
Apologies for the revertion. Should've got your okay first
Related to https://github.com/getlantern/grants/issues/468
Fixes the recursion panic in the issue. I've also amended the README a bit with unrelated comments.
Bug repro steps for reference:
mainbranch: 80f75db./scripts/run_avd.rb --level=30 --abi=x86_64 --use_google_apis --windowto spin a new emumake -B android-lib-prod ANDROID_ARCH=all && flutter run