Use application exclusion instead of socket protector to keep Lantern… #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… connections from being captured by VPN
soltzen
approved these changes
Jul 14, 2022
|
I can't reproduce the CI failure locally, I'll look into that separately. Thanks @soltzen ! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… connections from being captured by VPN
This accomplishes two main things:
It solves an intermittent problem whereby the Replica video player's traffic gets captured by the VPN and the flashlight code is unable to connect to the local Replica listener that's on localhost
It dramatically simplifies our code because we don't have to worry about using netx to plug in to the socket protection mechanism.