Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Switch to Go 1.18 #783

Merged
merged 1 commit into from
Aug 24, 2022
Merged

Switch to Go 1.18 #783

merged 1 commit into from
Aug 24, 2022

Conversation

oxtoacart
Copy link

No description provided.

@oxtoacart oxtoacart requested a review from Crosse August 24, 2022 14:35
Copy link
Contributor

@Crosse Crosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, still failing. 😢 I think we'll need to do one of a few things:

  1. don't run the race detector during tests here;
  2. bring back the assembly versions of commitSleep() in netstack;
  3. figure out if netstack/sleep/commit.go really needs the !race build directive and if not, remove that restriction.

I've tested all three options and they all produce succesful test runs with Go 1.18. I'd say option 2 is the way to go (barring a reason for not using the asm versions—there isn't one isn't mentioned in getlantern/netstack#7 but you may remember there being an issue with them), followed by option 3.

Downgrade CI to Go 1.17

Disable race detection for running tests as it breaks netstack

Switch to go 1.18
@oxtoacart oxtoacart changed the title Upgraded to netstack supporting up to Go 1.19 Switch to Go 1.18 Aug 24, 2022
@oxtoacart
Copy link
Author

@Crosse This fixes the test issue.

@oxtoacart oxtoacart merged commit ef476f4 into main Aug 24, 2022
@oxtoacart oxtoacart deleted the update-replica-dep branch August 24, 2022 18:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants