Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

perf(keto-client-wrapper): improve AuthorizationGuard performance by combining permission checks #105

Open
getlarge opened this issue Oct 7, 2024 · 2 comments · May be fixed by #106
Open

perf(keto-client-wrapper): improve AuthorizationGuard performance by combining permission checks #105

getlarge opened this issue Oct 7, 2024 · 2 comments · May be fixed by #106

Comments

@getlarge
Copy link
Owner

getlarge commented Oct 7, 2024 •
edited
Loading

The Ory Keto PermissionApi contains a batchCheckPermission (why did I miss it?).
It could be used to run all permissions checks in a single request, which would offer great performance improvements for nested conditions!

  1. Find a way to flatten the conditions without losing the requirement info
  2. Resolve the tuple's templates
  3. Run the batchCheckPermission
  4. Compare the results (Array<{ allowed: boolean, error?: string }>) based on the array index.
@getlarge
Copy link
Owner Author

getlarge commented Oct 7, 2024

I understand why I missed it. It is a very recent addition, see this changelog.
It might not yet be available in the HTTP API...

@getlarge
Copy link
Owner Author

getlarge commented Oct 7, 2024 •
edited
Loading

I need to wait for the new release of Ory Keto on GitHub and Docker Hub.

@getlarge getlarge linked a pull request Oct 7, 2024 that will close this issue
Open
@getlarge getlarge linked a pull request Oct 7, 2024 that will close this issue
perf: improve OryAuthorizationGuard performance by combining permission checks #106
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@getlarge