Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Don't require a label for Entity updates #6511

Open
lognaturel opened this issue Nov 14, 2024 · 0 comments · May be fixed by #6515
Open

Don't require a label for Entity updates #6511

lognaturel opened this issue Nov 14, 2024 · 0 comments · May be fixed by #6515
Assignees
Labels

Comments

@lognaturel
Copy link
Member

lognaturel commented Nov 14, 2024

ODK Collect version

v2024.3.0 beta 8

Problem description

Entity updates without an explicit label fail silently.

Steps to reproduce the problem

  1. Remove the value for the label Entity property for a form that updates Entities such as this one
  2. Make sure that there is the offline column on the entities sheet and that its value is set to yes
  3. Fill out and finalize a submission
  4. See that the local Entity update was not applied

Expected behavior

Labels should be optional for Entity updates. Just like with other properties, if no value is specified in the update, the existing value should be carried forward. Label is required at creation time so there should always be one at update time.

Other information

I think this likely came from a misunderstanding around #6453 Labels are required for Entity creation but optional for updates.

@lognaturel lognaturel added the bug label Nov 14, 2024
@grzesiek2010 grzesiek2010 self-assigned this Nov 15, 2024
@grzesiek2010 grzesiek2010 moved this from inbox to in progress in ODK Collect Nov 15, 2024
@grzesiek2010 grzesiek2010 linked a pull request Nov 15, 2024 that will close this issue
6 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
Status: in progress
Development

Successfully merging a pull request may close this issue.

2 participants