Reworked the banner in Ready to send screen using card view #6429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we left align all the text? Now that I'm seeing it, we have space to bring the icon and text closer together in the card. Otherwise, I think this looks really good and it anchors the page well. |
Just text or the icon too? If we align both it will be like this: |
|
Aligning the text was the only issue. I thought the icon looked fine before because the gap with the text looks too big. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6347
Why is this the best possible solution? Were any other approaches considered?
I tried making the custom
ReadyToSendBannerview extendMaterialCardView, but it displayed gray background corners that I couldn't remove (this might be an Android bug). The solution was to wrap it in an additionalFrameLayout, which may seem redundant at first glance.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
The only change is the visual representation of the banner in
Ready to send. Its functionality remains the same.Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest