Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Porter explain yield error on release/v1 branch #1945

Closed
joshuabezaleel opened this issue Feb 26, 2022 · 5 comments
Closed

Porter explain yield error on release/v1 branch #1945

joshuabezaleel opened this issue Feb 26, 2022 · 5 comments
Labels
bug Oops, sorry!

Comments

@joshuabezaleel
Copy link
Contributor

Describe the bug

Porter explain ran with a build from release/v1 yield error while it works with the v0.38 (porter v0.38.7 (43a2b2ae)) with the same bundle getporter/porter-hello:v0.1.0.

To Reproduce

Steps to reproduce the behavior:

  1. Clone the latest version from release/v1 branch.
  2. Run make build.
  3. Use the binary to run porter explain --reference getporter/porter-hello:v0.1.0.

Expected behavior

Output of the explain command will be shown like the porter v0.38.7 does.

Porter Command and Output

image
image

Version

porter v1.0.0-alpha.8-67-gecedc49b (ecedc49)

@joshuabezaleel joshuabezaleel added the bug Oops, sorry! label Feb 26, 2022
@joshuabezaleel
Copy link
Contributor Author

Found this while trying to work on #904

@carolynvs
Copy link
Member

@joshuabezaleel Can you try this with the most recent tag for that bundle? v0.1.1 supports porter v1, the original was written for the older version.

@joshuabezaleel
Copy link
Contributor Author

Ah yes it works, now that explains. Would this be addressed in the future with this particular issue of #1566 for a better error message?

I will be closing the issue. Thank you lots Carolyn 🙂

@carolynvs
Copy link
Member

I've been working on #1566 for a bit, and just opened a draft PR so people can see how far along the work is. I'll update that issue with a requirement that all commands that pull a bundle should check the schema version before trying to parse the manifest to avoid problems like this.

@joshuabezaleel
Copy link
Contributor Author

That would be lovely. Thank you lots, Carolyn!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Oops, sorry!
Projects
None yet
Development

No branches or pull requests

2 participants