Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Restore private channel support #82

Open
mwarkentin opened this issue Jun 23, 2023 · 1 comment
Open

Restore private channel support #82

mwarkentin opened this issue Jun 23, 2023 · 1 comment
Labels

Comments

@mwarkentin
Copy link
Member

mwarkentin commented Jun 23, 2023

It'd be great if we're able to gib potatoes in pribate channels again (in a way that we're happy with security-wise).

I find myself gibing potatoes that don't work, or not gibbing a potato at all because I have to find a different channel to do it in.

@mwarkentin
Copy link
Member Author

mwarkentin commented Jun 26, 2023

All go transactions to the event endpoint had the message in their payload. We can remove them in the SDK. (Also, server side scrubbing was turned off as well).

image

Summarizing:

  • Messages which included 🥔 in private channels were sending the message text to gibpotato
  • All messages from private channels with gibpotato installed were being sent and filtered by the gibpotato golang service
  • gibpotato was not storing the messages itself, but our tracing was sending this data to sentry
  • We should scrub this data in the SDK
  • We should also look at configuring server-side scrubbing for this data

If we do this, could that be enough to re-enable gibpotato on our private channels?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants