Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adjust ASP.NET Core installation steps for .NET 6 #1381

Closed
bruno-garcia opened this issue Dec 13, 2021 · 5 comments
Closed

Adjust ASP.NET Core installation steps for .NET 6 #1381

bruno-garcia opened this issue Dec 13, 2021 · 5 comments

Comments

@bruno-garcia
Copy link
Member

bruno-garcia commented Dec 13, 2021

Migration docs from .NET 5 to 6 state:

When using the minimal hosting model, the endpoint routing middleware wraps the entire middleware pipeline, therefore there's no need to have explicit calls to UseRouting or UseEndpoints to register routes. UseRouting can still be used to specify where route matching happens, but UseRouting doesn't need to be explicitly called if routes should be matched at the beginning of the middleware pipeline.

Our current docs point out users must add our UseSentryTracing middleware after UseRouting. This can be confusing to users when they are no longer there.

Install steps must account for framework version: https://github.com/getsentry/sentry-docs/blob/master/src/wizard/dotnet/aspnetcore.md

@dragouf
Copy link

dragouf commented Jan 11, 2022

Is there a new doc for .net 6 ? I don't see how to configure sentry with this version ... Where to call UseSentry in Program.cs ?

[edit]: ok it may be that :

builder.WebHost.UseSentry();

but for performance log I'm not sure as it is mention in this ticket...

@bruno-garcia
Copy link
Member Author

Relates to: #1453

@bruno-garcia
Copy link
Member Author

builder.WebHost.UseSentry();

var app = builder.Build();

app.UseSentryTracing();

@SimonCropp
Copy link
Contributor

current plan is to update https://github.com/getsentry/sentry-docs/blob/master/src/wizard/dotnet/aspnetcore.md to target the current stable. ie net6

@SimonCropp SimonCropp moved this from Needs Discussion to Backlog in Mobile & Cross Platform SDK Mar 23, 2022
@bitsandfoxes bitsandfoxes added this to GDX Nov 20, 2023
@bitsandfoxes
Copy link
Contributor

Parts of this have been addressed in #2726 and our documentation regarding a limitation when calling UseRouting explicitly has been updated.

@github-project-automation github-project-automation bot moved this to Done in GDX Sep 5, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
Status: Done
Archived in project
Development

No branches or pull requests

5 participants