Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Serilog verbose logs appearing as errors #213

Closed
mariusz-schimke-iteo opened this issue May 31, 2019 · 3 comments · Fixed by #217
Closed

Serilog verbose logs appearing as errors #213

mariusz-schimke-iteo opened this issue May 31, 2019 · 3 comments · Fixed by #217
Labels
Bug Something isn't working Good First Issue Good for newcomers

Comments

@mariusz-schimke-iteo
Copy link

Logs generated with the Verbose(...) method of Serilog appear as errors on Sentry. Sentry seems not to support the verbose log level, but mapping these to errors seems to be incorrect. How about mapping them to debug logs by default?

@bruno-garcia bruno-garcia added the Bug Something isn't working label May 31, 2019
@bruno-garcia
Copy link
Member

Right! Verbose should map to Debug. This sounds like a bug.

@kanadaj
Copy link
Contributor

kanadaj commented Jun 2, 2019

Verbose isn't logged at all, need to check why it turns into an error. Will pick up this one @bruno-garcia , will do a PR in a bit

@kanadaj
Copy link
Contributor

kanadaj commented Jun 2, 2019

Ah yes, missing mapping combined with

if (@event.Level == null)
{
    @event.Level = SentryLevel.Error;
}

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Bug Something isn't working Good First Issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants