From 286f6b009241170ee843779a598aefde4b146c2c Mon Sep 17 00:00:00 2001 From: Francesco Gringl-Novy Date: Tue, 14 Jan 2025 13:17:41 +0100 Subject: [PATCH] test(v8/e2e): Fix node-express test transitive dependency (#15004) It seems that `@types/qs` v 6.9.18 which was just released breaks this somehow... Backport of https://github.com/getsentry/sentry-javascript/pull/15001 --- .../test-applications/node-express/package.json | 9 ++++++--- .../test-applications/node-express/tsconfig.json | 2 +- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/dev-packages/e2e-tests/test-applications/node-express/package.json b/dev-packages/e2e-tests/test-applications/node-express/package.json index bc0b9b4dead7..b42a17fd5438 100644 --- a/dev-packages/e2e-tests/test-applications/node-express/package.json +++ b/dev-packages/e2e-tests/test-applications/node-express/package.json @@ -15,9 +15,9 @@ "@sentry/node": "latest || *", "@trpc/server": "10.45.2", "@trpc/client": "10.45.2", - "@types/express": "4.17.17", - "@types/node": "18.15.1", - "express": "4.20.0", + "@types/express": "^4.17.21", + "@types/node": "^18.19.1", + "express": "^4.21.2", "typescript": "4.9.5", "zod": "~3.22.4" }, @@ -25,6 +25,9 @@ "@playwright/test": "^1.44.1", "@sentry-internal/test-utils": "link:../../../test-utils" }, + "resolutions": { + "@types/qs": "6.9.17" + }, "volta": { "extends": "../../package.json" } diff --git a/dev-packages/e2e-tests/test-applications/node-express/tsconfig.json b/dev-packages/e2e-tests/test-applications/node-express/tsconfig.json index 8cb64e989ed9..ce4fafb745ad 100644 --- a/dev-packages/e2e-tests/test-applications/node-express/tsconfig.json +++ b/dev-packages/e2e-tests/test-applications/node-express/tsconfig.json @@ -2,7 +2,7 @@ "compilerOptions": { "types": ["node"], "esModuleInterop": true, - "lib": ["es2018"], + "lib": ["es2020"], "strict": true, "outDir": "dist" },